Re: 1.10 API review - svn_io_stdin_readline()

On Mon, Jan 15, 2018 at 04:42:02PM +0000, Julian Foad wrote:
> About this new-for-1.10 API:
> [[[
> /** Reads a string from stdin until a newline or EOF is found
> *
> * @since New in 1.10.
> */
> svn_error_t *
> svn_io_stdin_readline(const char **result,
> apr_pool_t *result_pool,
> apr_pool_t *scratch_pool);
> ]]]
>
> Compare with svn_stream_readline() and svn_io_file_readline():
> * they read into a svn_stringbuf_t;
> * they have EOL and EOF params;
> * svn_io_file_readline() has max_len param;
>
> It seems to me it would be better to make this new function more similar to
> them.
>
> Thoughts?
>
> - Julian

I wouldn't disagree with any such changes. Consistency is good!

There's currently only one use case for this function (read a password
from stdin) but these callers could easily be adapted.
Received on 2018-01-15 22:23:07 CET