Re: svn commit: rev 2092 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/tests/libsvn_wc

Greg Stein <gstein@lyra.org> writes:
> Batons are pointers to arbitrary data. The traversal information doesn't
> follow that pattern, so I think you should make the type explicit. Let the
> compiler ensure that the correct structure is passed around. In other words:
>
> typedef struct svn_wc_traversal_info svn_wc_traversal_info;
>
> And then define the structure in libsvn_wc/something_or_other

That seems like a good idea. I made it opaque more out of unthinking
reflex than any compelling design principle.

> > + /* What revision to check out. Only svn_client_revision_number,
> > + svn_client_revision_date, and svn_client_revision_head are
> > + valid. ### Any reason to change this to inline, instead of
> > + pointer? */
> > + svn_client_revision_t *revision;
>
> I'd recommend making it inline. It simplifies the setup of the structures
> (single alloc rather than multiple and hooking them together).

Thanks for answering the comment.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 6 05:57:17 2002